dsmiley commented on code in PR #3524:
URL: https://github.com/apache/solr/pull/3524#discussion_r2309185575
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1134,39 +1128,18 @@ public Builder useOtherCollectionConfigSetExecution() {
* debugging tests</b> failing in only one of the two modes to have all
local runs exhibit the
* issue, as well obviously for tests that are not compatible with one of
the two modes.
*
- * <p>If this method is not called, the strategy being used will be random
if the configuration
- * passed to the cluster ({@code solr.xml} equivalent) contains a
placeholder similar to:
+ * <p>If this method is not called, the strategy being used will default
to Overseer mode
+ * (overseerEnabled=true) unless explicitly configured (cluster property
or sys prop).
*
- * <pre>{@code
- * <solrcloud>
- * ....
- * <str
name="distributedClusterStateUpdates">${solr.distributedClusterStateUpdates:false}</str>
- * <str
name="distributedCollectionConfigSetExecution">${solr.distributedCollectionConfigSetExecution:false}</str>
- * ....
- * </solrcloud>
- * }</pre>
+ * <p>For tests that need to explicitly test distributed vs Overseer
behavior, use this method
+ * to control which mode is used. The cluster property 'overseerEnabled'
will be set
+ * accordingly.
*
- * For an example of a configuration supporting this setting, see {@link
- * MiniSolrCloudCluster#DEFAULT_CLOUD_SOLR_XML}. When a test sets a
different {@code solr.xml}
- * config (using {@link #withSolrXml}), if the config does not contain the
placeholder, the
- * strategy will be defined by the values assigned to {@code
useDistributedClusterStateUpdates}
- * and {@code useDistributedCollectionConfigSetExecution} in {@link
- * org.apache.solr.core.CloudConfig.CloudConfigBuilder}.
- *
- * @param distributedCollectionConfigSetApi When {@code true}, Collection
and Config Set API
- * commands are executed in a distributed way by nodes. When {@code
false}, they are
- * executed by Overseer.
- * @param distributedClusterStateUpdates When {@code true}, cluster state
updates are handled in
- * a distributed way by nodes. When {@code false}, cluster state
updates are handled by
- * Overseer.
- * <p>If {@code distributedCollectionConfigSetApi} is {@code true}
then this parameter must
- * be {@code true}.
+ * @param overseerEnabled When {@code true}, Collection and Config Set API
commands are executed
Review Comment:
I need to flip that explanation
##########
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##########
Review Comment:
again; no reason to create another DistributedClusterStateUpdater here
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/DistributedCollectionCommandContext.java:
##########
Review Comment:
no reason to create a new DistributedClusterStateUpdater here; we can take
the existing one in ZkController
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
