dsmiley commented on code in PR #3604:
URL: https://github.com/apache/solr/pull/3604#discussion_r2317633770
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java:
##########
@@ -702,13 +700,6 @@ public static void createCollectionZkNode(
}
}
- // if the config name wasn't passed in, use the default
- if (!collectionProps.containsKey(ZkController.CONFIGNAME_PROP))
- collectionProps.put(ZkController.CONFIGNAME_PROP,
defaultConfigName);
Review Comment:
I took a fresh look at createCollectionZkNode. There's definitely some
legacy logic here that I'd love to see gone. Only 2 lines are for
bootstrap_conf, which you removed (an else-if); thanks. I think the
"bootstrap_conf" else-if block can entirely go as well (~18 lines)! IMO All we
want this newly renamed system property to do is to bootstrap a configset into
ZooKeeper -- that's it. We don't need it to have special side meanings when a
collection is created, which is the context we're looking at here. We'll need
to communicate something in upgrades. I think we can say:
> The system property "bootstrap_conf" (recently renamed) used to allow a
collection creation command to default to the examination of system properties
in the absence of proper creation parameters by the same name (like
"collection.configName"). That no longer happens in Solr 10.
Good riddance :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
