Copilot commented on code in PR #3071:
URL: https://github.com/apache/solr/pull/3071#discussion_r2318149096
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientCompatibilityTest.java:
##########
@@ -36,11 +36,13 @@ public class Http2SolrClientCompatibilityTest extends
SolrJettyTestBase {
public void testSystemPropertyFlag() {
System.setProperty("solr.http1", "true");
try (Http2SolrClient client = new Http2SolrClient.Builder().build()) {
- assertTrue(client.getHttpClient().getTransport() instanceof
HttpClientTransportOverHTTP);
+ assertTrue(
+ client.getHttpClient().getHttpClientTransport() instanceof
HttpClientTransportOverHTTP);
Review Comment:
The API change from getTransport() to getHttpClientTransport() suggests a
breaking change in Jetty 12.1.0. Ensure this change is documented in release
notes and verify that all other code using the old API has been updated.
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -530,7 +530,7 @@ public int getSegmentCount() {
return withSearcher(
solrIndexSearcher ->
solrIndexSearcher.getRawReader().getIndexCommit().getSegmentCount());
} catch (IOException e) {
- throw new RuntimeIOException(e);
+ throw new UncheckedIOException(e);
Review Comment:
The replacement of RuntimeIOException with UncheckedIOException is correct
as RuntimeIOException was likely removed from Jetty 12.1.0. However, verify
that the behavior is identical - both are runtime exceptions that wrap
IOException.
##########
solr/core/build.gradle:
##########
@@ -119,7 +119,6 @@ dependencies {
implementation libs.eclipse.jetty.client
implementation libs.eclipse.jetty.http
Review Comment:
The removal of explicit jetty-io dependency suggests it's now transitively
included. Verify that this doesn't cause issues with dependency resolution or
that the required classes are still available at runtime.
```suggestion
implementation libs.eclipse.jetty.http
implementation libs.eclipse.jetty.io
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
