ercsonusharma commented on code in PR #3418:
URL: https://github.com/apache/solr/pull/3418#discussion_r2319177772


##########
solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java:
##########
@@ -82,6 +82,14 @@ public void prepare(ResponseBuilder rb) throws IOException {
       rb.setNeedDocSet(true);
       rb.doFacets = true;
 
+      if (rb instanceof CombinedQueryResponseBuilder crb) {
+        crb.responseBuilders.forEach(
+            thisRb -> {
+              thisRb.setNeedDocSet(true);
+              thisRb.doFacets = true;
+            });
+      }
+

Review Comment:
   Please see a method created `propagate` to take care of this. 
   
   - Please see a test for highlighter where we need to provide a query in hl.
   - We are combining the docSet using union which would help coombining the 
facets.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to