dsmiley commented on code in PR #3617:
URL: https://github.com/apache/solr/pull/3617#discussion_r2323692568
##########
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##########
@@ -77,7 +78,7 @@ public class SystemInfoHandler extends RequestHandlerBase {
* @see #initHostname
*/
private static final String PREVENT_REVERSE_DNS_OF_LOCALHOST_SYSPROP =
- "solr.dns.prevent.reverse.lookup";
+ "solr.admin.handler.systeminfo.dns.prevent.reverse.lookup.enabled";
Review Comment:
The "enabled" suffix exposes an inversion of expressing what we're going to
do. Arguably boolean settings should express what we *will* do, which aligns
with your opinionated stance on using "enabled" instead of "disabled". Thus we
could drop the "prevent" there and flip the meaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
