bjacobowitz opened a new pull request, #3624: URL: https://github.com/apache/solr/pull/3624
https://issues.apache.org/jira/browse/SOLR-17806 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-17806: Move SolrMetricTestUtils to test-framework SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Move `SolrMetricTestUtils` from the test source set of `core` into the main source set of `test-framework`. Asserting metric values is sometimes implemented in parent test classes, e.g. in [SolrCloudAuthTestCase](https://github.com/apache/solr/blob/fda4c40f53c8f44de9970d547fd7f6a6d6d6a924/solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudAuthTestCase.java#L100-L141). `SolrMetricTestUtils` provides a convenient way to pull metrics from a core container, and that functionality needs to be available to the test framework. It ends up being necessary for migrating the auth metrics. Those are distributed across a few modules (e.g. solr.core for the main security tests but also solr.modules.jwt-auth for the jwt plugin), so leaving `SolrMetricTestUtils` in `solr.core` ends up being pretty much unworkable. Also, I think the name of the class indicates that it's a testing utility with wide applicability, and it makes a fair bit of sense for that to live with all the other testing utilities. # Solution Move `SolrMetricTestUtils` from the test source set of `core` into the main source set of `test-framework`. # Tests The tests continue to pass. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
