dsmiley commented on code in PR #3627:
URL: https://github.com/apache/solr/pull/3627#discussion_r2327879370
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1108,20 +1108,6 @@ public Builder addConfig(String configName, Path
configPath) {
return this;
}
- /**
- * This method makes the MiniSolrCloudCluster use the "other" Collection
API execution strategy
- * than it normally would. When some test classes call this method (and
some don't) we make sure
- * that a run of multiple tests with a single seed will exercise both code
lines (distributed
- * and Overseer based Collection API) so regressions can be spotted faster.
- *
- * <p>The real need is for a few tests covering reasonable use cases to
call this method. If
- * you're adding a new test, you don't have to call it (but it's ok if you
do).
- */
- public Builder flipOverseerEnablement() {
- overseerEnabled = !overseerEnabled;
- return this;
- }
-
Review Comment:
I think there's no point to this really. It's randomly set by
SolrCloudTestCase. A test can explicitly set it one way or the other if it
wants to (and some do).
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1181,7 +1167,7 @@ public MiniSolrCloudCluster configure() throws Exception {
* @throws Exception if an error occurs on startup
*/
public MiniSolrCloudCluster build() throws Exception {
- this.clusterProperties.put(ZkStateReader.OVERSEER_ENABLED,
Boolean.toString(overseerEnabled));
+ System.setProperty("solr.cloud.overseer.enabled",
Boolean.toString(overseerEnabled));
Review Comment:
Because there's a deficiency in MiniSolrCloudCluster in which cluster
properties get set later (after node start) instead of early. Not a big deal
to do this instead since an entire test is going to set this one way or the
other; not vary per cluster. I'd rather a separate PR improve that specific
matter but I'm not sure I'll get to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
