hossman commented on PR #3609: URL: https://github.com/apache/solr/pull/3609#issuecomment-3267156276
Why comment them out? just delete them. IIRC the point of these assertions was to verify that the group head selection logic using `sort` would be consistent with what doc (in each group) would come first if you did *NOT* use collapse and instead filtered on the group using that sort -- and once upon a time that ment that (sort) ties were broken by index order, so the test was trying to prove the same tie breaker was used here (ie: first doc wins, not last doc) if index order as a sorting tiebreaker is no longer a reliable guarantee at the lucene level, then just rip out these lines of testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
