ercsonusharma commented on code in PR #3418:
URL: https://github.com/apache/solr/pull/3418#discussion_r2352932992
##########
solr/core/src/test/org/apache/solr/handler/component/CombinedQueryComponentTest.java:
##########
@@ -21,39 +21,59 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
-import org.apache.solr.SolrTestCaseJ4;
+import org.apache.solr.BaseDistributedSearchTestCase;
+import org.apache.solr.client.solrj.response.QueryResponse;
import org.apache.solr.common.SolrException;
import org.apache.solr.common.SolrInputDocument;
import org.apache.solr.common.params.CommonParams;
+import org.apache.solr.common.util.SimpleOrderedMap;
import org.junit.BeforeClass;
import org.junit.Test;
/**
* The CombinedQueryComponentTest class is an integration test suite for the
CombinedQueryComponent
- * in Solr. It verifies the functionality of the component by performing few
basic queries and
- * validating the responses including limitations and combiner plugin.
+ * in Solr. It verifies the functionality of the component by performing few
basic queries in single
+ * sharded mode and validating the responses including limitations and
combiner plugin.
*/
-public class CombinedQueryComponentTest extends SolrTestCaseJ4 {
+public class CombinedQueryComponentTest extends BaseDistributedSearchTestCase {
Review Comment:
Since, the algorithm doesn't support non-distributed request anymore, it
didn't make sense to add test cases by extending SolrTestCaseJ4 so I have
changed it. However, this class can be merged with other CombinedQueryTest but
the key idea was: `The class verifies the functionality of the component by
performing few basic queries in single sharded mode and validating the
responses including limitations and combiner plugin.`
If you feel it should be merged to other test classes, I am open to making
those changes when we finalise [this
one](https://github.com/apache/solr/pull/3418#discussion_r2331983004)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
