epugh commented on code in PR #3699: URL: https://github.com/apache/solr/pull/3699#discussion_r2379969979
########## solr/core/src/java/org/apache/solr/core/SolrCores.java: ########## @@ -95,6 +90,7 @@ protected void close() { // It might be possible for one of the cores to move from one list to another while we're // closing them. So loop through the lists until they're all empty. In particular, the core + // NOCOMMIT I think i need help on determing what to do here. Review Comment: @dsmiley I am hoping you can weigh in on this. Is there some code to be removed/simplified in a no transient core world? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org