jkmuriithi commented on code in PR #3509:
URL: https://github.com/apache/solr/pull/3509#discussion_r2383424479
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1018,8 +1040,52 @@ private void loadInternal() {
"unloaded",
SolrInfoBean.Category.CONTAINER.toString(),
"cores");
+
Path dataHome =
cfg.getSolrDataHome() != null ? cfg.getSolrDataHome() :
cfg.getCoreRootDirectory();
+
+ solrMetricsContext.observableLongGauge(
+ "solr_cores_filesystem_disk_space",
+ "Disk metrics for Solr's data home directory",
Review Comment:
When aggregating, do we need metrics to have consistent descriptions? Or is
it OK if each replica reports a different description under the same metric
name? @mlbiscoc I'm not too familiar with the specifics of OTEL so maybe you
could chime in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
