rahulgoswami commented on code in PR #3685:
URL: https://github.com/apache/solr/pull/3685#discussion_r2383492843
##########
gradle/help.gradle:
##########
@@ -19,17 +19,17 @@
configure(rootProject) {
def helpFiles = [
- ["Workflow", "help/workflow.txt", "Typical workflow commands."],
- ["Ant", "help/ant.txt", "Ant-gradle migration help."],
- ["Tests", "help/tests.txt", "Tests, filtering, beasting, etc."],
- ["Formatting", "help/formatting.txt", "Code formatting conventions."],
- ["Deps", "help/dependencies.txt", "Declaring, inspecting and excluding
dependencies."],
- ["ForbiddenApis", "help/forbiddenApis.txt", "How to add/apply rules for
forbidden APIs."],
- ["LocalSettings", "help/localSettings.txt", "Local settings, overrides
and build performance tweaks."],
- ["Git", "help/git.txt", "Git assistance and guides."],
- ["ValidateLogCalls", "help/validateLogCalls.txt", "How to use logging
calls efficiently."],
- ["Publishing", "help/publishing.txt", "Release publishing publishing,
signing, etc."],
- ["Docker", "solr/docker/gradle-help.txt", "Building Solr Docker
images."],
+ ["Workflow", "dev-docs/gradle-help/workflow.txt", "Typical workflow
commands."],
+ ["Ant", "dev-docs/gradle-help/ant.txt", "Ant-gradle migration help."],
+ ["Tests", "dev-docs/gradle-help/tests.txt", "Tests, filtering, beasting,
etc."],
+ ["Formatting", "dev-docs/gradle-help/formatting.txt", "Code formatting
conventions."],
+ ["Deps", "dev-docs/gradle-help/dependencies.txt", "Declaring, inspecting
and excluding dependencies."],
Review Comment:
all other help task names seem to have the format "gradlew help<filename in
help>". And hence I thought we could be consistent that way even with
"dependencies"(?) It's a knit pick.
I just tend to reference the dependencies.txt often while building Solr from
a local lucene repo and so that was the one that immediately caught my
attention :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
