mlbiscoc commented on code in PR #3713: URL: https://github.com/apache/solr/pull/3713#discussion_r2403007945
########## solr/core/src/java/org/apache/solr/cluster/placement/impl/NodeMetricImpl.java: ########## @@ -17,108 +17,51 @@ package org.apache.solr.cluster.placement.impl; -import java.util.Objects; import java.util.function.Function; -import org.apache.solr.client.solrj.impl.NodeValueFetcher; import org.apache.solr.cluster.placement.NodeMetric; -/** - * Node metric identifier, corresponding to a node-level metric registry and the internal metric - * name. - */ +/** Node metric identifier, corresponding to a node-level metric name with labels */ Review Comment: So I didn't remove them, I just moved them when I was first working on this. But looking back, I think it actually belongs here so moved the constants back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
