epugh commented on code in PR #3710:
URL: https://github.com/apache/solr/pull/3710#discussion_r2403162169
##########
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/utils/Helpers.java:
##########
@@ -46,12 +51,35 @@ public static void indexAllDocs(SolrClient client) throws
IOException, SolrServe
ContentStreamUpdateRequest req = new
ContentStreamUpdateRequest("/update");
try {
req.addFile(xml, "application/xml");
- client.request(req, PrometheusExporterTestBase.COLLECTION);
+ NamedList<Object> response =
Review Comment:
@dsmiley I am a bit worried about this change. I was getting ObjectTracker
errors until I added this. Seems a bit worrisome that we might have unclosed
streams unless we actually consume them.. Is this a potential issue with our
InputStreamResponseParser? Do we need it to internally close the stream in
the `STREAM_KEY` if it isn't actually read?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
