bruno-roustant commented on code in PR #126:
URL: https://github.com/apache/solr-sandbox/pull/126#discussion_r2412651598
##########
encryption/src/test/java/org/apache/solr/encryption/EncryptionTestUtil.java:
##########
@@ -234,9 +236,10 @@ public void waitUntilEncryptionIsComplete(String keyId)
throws InterruptedExcept
} catch (Exception e) {
throw new RuntimeException(e);
}
- assertTrue(encryptionStatus.success);
Review Comment:
The encryption request success status may be false transiently because of
connection errors for example. The current code fails immediately with an
assertion, whereas the new code retries until the timeout and asserts at the
end.
In our CI we have seen this code flapping these days because of this reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
