[ 
https://issues.apache.org/jira/browse/SOLR-17896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18021861#comment-18021861
 ] 

ASF subversion and git services commented on SOLR-17896:
--------------------------------------------------------

Commit c4e70b1d34f675496c45fe46b40baffecf0c0449 in solr's branch 
refs/heads/main from Christos Malliaridis
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=c4e70b1d34f ]

SOLR-17896: Introduce reusable navigation tabs (#3656)

Implements the navigation tabs component  in a reusable way and applies it to 
Configsets and Cluster for demonstration.

The implementation does not apply styling from the designs, because the used 
composables from Material are not easily customized. The current implementation 
is also more accessible, as the expected designs used only a color indicator 
for the current selection, and the implementation uses an indicator line.

This PR is based on #3521.

---------

Co-authored-by: Sanjay Dutt <[email protected]>

> Implement a Reusable Tab Navigation Component
> ---------------------------------------------
>
>                 Key: SOLR-17896
>                 URL: https://issues.apache.org/jira/browse/SOLR-17896
>             Project: Solr
>          Issue Type: Sub-task
>          Components: Admin UI
>            Reporter: Christos Malliaridis
>            Assignee: Christos Malliaridis
>            Priority: Major
>              Labels: new-ui, pull-request-available, ui
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Many of our sections come with tabs that divide top-level sections into 
> smaller sections. This can be implemented as a reusable component that can be 
> extended by the top-level componets and use a generic to dynamically load the 
> tabs.
> h2. Task
> Implement a tab navigation component (and/or migrate existing components) 
> that is reusable by other components.
> h2. Acceptance Criteria
> - The navigation component integration avoids duplication of code and logic
> - The navigation component is using well-defined (preferrably enums or sealed 
> classes / objects) values for the menu items
> - The implementation **may** output navigation events
> - The implementation **may** prevent conditionally navigation actions
>   - That is, when the user wants to navigate to different tab for example, 
> but there is an unsaved state currently present that will be lost on 
> navigation
> - The styles from the Figma designs (see section's header, most of them have 
> tabs, e.g. for 
> [configsets|https://www.figma.com/design/VdbEfcWQ8mirFNquBzbPk2/Apache-Solr-Admin-UI-v2-Concept?node-id=227-7661&t=yxFihPpG3r7FXACm-1])
>  are appled.
> h2. Additional Information
> The navigation component may be added to the following sections:
> - Metrics
> - Cluster
> - Security (note here the different navigation tabs based on current security 
> configuration)
> - Configsets
> - Collections
> - Logging
> See the current [figma 
> designs|https://www.figma.com/design/VdbEfcWQ8mirFNquBzbPk2/Apache-Solr-Admin-UI-v2-Concept?node-id=87-12957&t=Nn13TbrCARmj2IrX-1]
>  for details about each section's tabs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to