malliaridis commented on code in PR #3670:
URL: https://github.com/apache/solr/pull/3670#discussion_r2422105312
##########
solr/modules/extraction/gradle.lockfile:
##########
@@ -99,7 +102,8 @@
javax.inject:javax.inject:1=annotationProcessor,errorprone,testAnnotationProcess
javax.measure:unit-api:1.0=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
joda-time:joda-time:2.14.0=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
junit:junit:4.13.2=jarValidation,testCompileClasspath,testRuntimeClasspath
-net.java.dev.jna:jna:5.12.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
+net.java.dev.jna:jna:5.12.1=compileClasspath,runtimeClasspath,runtimeLibs
+net.java.dev.jna:jna:5.13.0=jarValidation,testCompileClasspath,testRuntimeClasspath
Review Comment:
This is a sign that we are not aligning the versions and we let the
transitive dependencies be out of sync. The easiest way to resolve this is to
add the library with the latest supported version, or the highest version from
the lock files (here 5.13.0) to the `libs.version.toml` (remember to include
the `# keep` comment to prevent tidy from removing it). It will then align the
versions across the project. The addition would be something like
```toml
[versions]
# ...
jna = "5.13.0"
# ...
[libraries]
# ...
jna-jna = { module = "net.java.dev.jna:jna", version.ref = "jna" }
# ...
```
If that does not solve the issue, then we likely do not depend on our
`platform` module, either transitive through `solr:api` or directly (through
dependency on `platform(project(":platform"))`). To fix this case, add in
addition to the above also the `[configuration] platform(project(":platform"))`
to the module's gradle file, where configuration is usually one of the
configuration listed in the lockfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
