[ 
https://issues.apache.org/jira/browse/SOLR-17940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18024169#comment-18024169
 ] 

ASF subversion and git services commented on SOLR-17940:
--------------------------------------------------------

Commit 5782bdc0b650b1e1a09a1b5e0260785f3e13d95e in solr's branch 
refs/heads/main from Chris M. Hostetter
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=5782bdc0b65 ]

SOLR-17940: Fix DelegatingCollector to prevent the delegate from calling 
setMinCompetitiveScore if the scoreMode is not TOP_SCORES


> DelegatingCollector needs to filter Scorable depending on scoreMode
> -------------------------------------------------------------------
>
>                 Key: SOLR-17940
>                 URL: https://issues.apache.org/jira/browse/SOLR-17940
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-17940.patch
>
>
> SOLR-17917 uncovered a test failure when trying to upgrade to Lucene 10.3, 
> which [was caused by a change in behavior 
> |https://github.com/apache/lucene/issues/15239]in lucene that is the result 
> of an optimization in scoring {{TermQuery}} instances.
> The problem manifests in Solr because of how {{DelegatingCollector}} 
> (subclasses) can change the {{scoreMode}} in a way which might be 
> inconsistent with if/how the delegate Collector may use 
> {{Scorable.setMinCompetitive}}.
> While it remains to be seen if the change in behavior in Lucene 10.3 is 
> _intentional_ or not, and/or if the docs for the {{ScoreMode}} are 
> inaccurate, practically speaking  {{DelegatingCollector}} can be updated to 
> be explicit about what should happen in these situations.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to