punAhuja opened a new pull request, #3747: URL: https://github.com/apache/solr/pull/3747
https://issues.apache.org/jira/browse/SOLR-17948 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Currently, when a document containing a primitive float[] or double[] field is sent to Solr using the JavaBin format, indexing fails because DenseVectorParser does not recognize primitive arrays as valid input types. Other loaders (like JSON or CSV) wrap vectors as lists, so this issue is specific to JavaBin. With this change, DenseVectorParser will be able to parse and index primitive float[] and double[] in the javabin. # Solution I have extended DenseVectorParser to handle float[] and double[] inputs in addition to the existing List-based formats. This change in solr-javabin-generator allows the JavaBin writer to serialize primitive float[] and double[] values directly, instead of boxing them into Lists. Link: https://github.com/SearchScale/solr-javabin-generator/pull/1 With this change, we can generate ~20% smaller javabin files, and DenseVectorParser in solr can read and index it. # Tests I added a small helper method that serializes a SolrInputDocument into JavaBin format and feeds it through JavabinLoader, so the test can simulate a real client sending JavaBin data to Solr. The two new tests verify that Solr correctly handles and indexes dense vector fields when the input is a primitive float[] or double[] coming from a JavaBin request. They confirm that the vectors are stored and returned properly in query results, just like list-based inputs from other loaders. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
