Copilot commented on code in PR #127: URL: https://github.com/apache/solr-sandbox/pull/127#discussion_r2430853029
########## gatling-simulations/README.md: ########## @@ -2,6 +2,18 @@ This module supports running performance benchmarks packaged and run as "Gatling simulations". +## Quickstart using Pre-Processed Data + +There is preprocessed data available at https://nightlies.apache.org/solr/benchmark-data/wiki/solr-wiki-batches-5k-1k.tar.gz. This tgz contains ~5k Solr-ready JSON files, each containing a batch of 5k wikipedia articles truncated at 1k each. + +1. Download pre-processed data: + `mkdir -p .gatling/batches && cd .gatling/batches && wget https://nightlies.apache.org/solr/benchmark-data/wiki/solr-wiki-batches-5k-1k.tar.gz && tar -xvf solr-wiki-batches-5k-1k.tar.gz` Review Comment: This command chain is quite long and complex. Consider breaking it into separate numbered steps for better readability and easier troubleshooting if any step fails. ```suggestion a. Create the batches directory: ``` mkdir -p .gatling/batches ``` b. Change into the batches directory: ``` cd .gatling/batches ``` c. Download the preprocessed data archive: ``` wget https://nightlies.apache.org/solr/benchmark-data/wiki/solr-wiki-batches-5k-1k.tar.gz ``` d. Extract the archive: ``` tar -xvf solr-wiki-batches-5k-1k.tar.gz ``` ``` ########## gatling-simulations/README.md: ########## @@ -19,7 +31,7 @@ This benchmark can be can be configured using the environment-variable knobs bel ## Running Built-In Scenarios -Built-in indexing scenarios will create a collection and delete it after the test completes. +Built-in indexing scenarios will create a collection and delete it after the test completes. You still need to load your own configset first. Review Comment: Extra space before 'You' - should be single space after period. ```suggestion Built-in indexing scenarios will create a collection and delete it after the test completes. You still need to load your own configset first. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
