gerlowskija opened a new pull request, #3720: URL: https://github.com/apache/solr/pull/3720
# Description Prior to this commit ZkController creates a ZkAclProvider, ZkCredentialsProvider, and ZkCredentialsInjector for its SolrZkClient to use, but then only passes along the ZkAclProvider. SolrZkClient has its own ZkCredentialsInjector fallback logic, but since ZkController and SolrZkClient can use different classloaders, relying on the fallback logic in SolrZkClient can cause ClassNotFoundException's in some cases. # Solution The fix is simple: tweak ZkController's initialization logic to actually use the ZkCredentialsProvider that it creates. # Tests Not really sure the best way to test this. Testing the ClassNotFoundException behavior would require a stub credentials-injector plugin that doesn't ship with Solr. Maybe we could refactor the SolrZkClient creation logic and introduce a unit test to verify that the created CredentialsProvider ends up being used, but that seems a little brittle and simplistic. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
