epugh commented on code in PR #3670: URL: https://github.com/apache/solr/pull/3670#discussion_r2408998078
########## solr/modules/extraction/src/java/org/apache/solr/handler/extraction/ExtractionRequest.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.extraction; + +import java.util.HashMap; +import java.util.Map; + +/** Immutable request info needed by extraction backends. */ +public class ExtractionRequest { + public final String streamType; // explicit MIME type (optional) + public final String resourceName; // filename hint + public final String contentType; // HTTP content-type header + public final String charset; // derived charset if available + public final String streamName; + public final String streamSourceInfo; + public final Long streamSize; + public final String resourcePassword; // optional password for encrypted docs + public final java.util.LinkedHashMap<java.util.regex.Pattern, String> + passwordsMap; // optional passwords map + public final String extractFormat; + public final boolean recursive; + public final Map<String, String> tikaRequestHeaders = new HashMap<>(); Review Comment: I'm okay with documenting them with `tikaServer`. Different backends will want different things. One thought, should we follow the same rules as for system properties. So dot lower case names? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
