jdyer1 opened a new pull request, #3730: URL: https://github.com/apache/solr/pull/3730
This makes the necessary changes to `Http2ClusterStateProvider` to allow it to work with any subclass of `HttpSolrClientBase`, namely `HttpJdkSolrClient`. This required one behavior change: callers must pass an instance of `HttpSolrClientBase` to the constructor. Passing `null` will result in an `IllegalArgumentException`. (Internally, only the unit test was relying on prior behavior) In addition method `withHttpClient` was added to `HttpJdkSolrClient.Builder`, allowing H2CSP to clone client instances with different base urls. Also a `builder()` method was added to the `HttpSolrClientBase` api so that H2CSP can obtain a builder of the correct type. The unit test randomly chooses to test either client implementation. In lieu of this approach, I considered creating a new class for the JDK client, leaving H2CSP unchanged. It seems better to make these value-add clients generic rather than creating yet more class variants. This PR is targeted for main/10.x only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
