epugh commented on code in PR #3768:
URL: https://github.com/apache/solr/pull/3768#discussion_r2433205270
##########
solr/solrj/src/java/org/apache/solr/client/solrj/util/SolrIdentifierValidator.java:
##########
@@ -60,10 +60,10 @@ public static String validateCoreName(String coreName) {
}
private static boolean validateIdentifier(String identifier) {
- if (identifier == null ||
!identifierPattern.matcher(identifier).matches()) {
- return false;
+ if (identifier != null && identifierPattern.matcher(identifier).matches())
{
Review Comment:
i actually had that, and then ended up backing it out. Sometimes I like the
more verbose ness...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
