iamsanjay commented on code in PR #3792:
URL: https://github.com/apache/solr/pull/3792#discussion_r2443230915
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -2306,12 +2306,12 @@ private ZkCoreNodeProps waitForLeaderToSeeDownState(
}
// short timeouts, we may be in a storm and this is just best effort,
and maybe we should be
- // the
- // leader now
+ // the leader now
+ // TODO .withHttpClient(getCoreContainer().getDefaultHttpSolrClient())
try (SolrClient client =
- new Builder(leaderBaseUrl)
+ new Http2SolrClient.Builder(leaderBaseUrl)
.withConnectionTimeout(8000, TimeUnit.MILLISECONDS)
- .withSocketTimeout(30000, TimeUnit.MILLISECONDS)
+ .withIdleTimeout(30000, TimeUnit.MILLISECONDS)
.build()) {
Review Comment:
What about the security listeners?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
