janhoy commented on code in PR #3784:
URL: https://github.com/apache/solr/pull/3784#discussion_r2444057748


##########
solr/packaging/test/test_extraction.bats:
##########
@@ -20,6 +20,8 @@ load bats_helper
 
 setup() {
   common_clean_setup
+  # NOCOMMIT: This test must somehow start a TikaServer on random port
+  # and define a $TIKA_PORT variable

Review Comment:
   Went further with the idea and with a little bit of retry logic and 
`setup_file()` hooks, this test now
   * Skips and passes if docker is not available
   * Starts a TikaServer with docker on port `SOLR_PORT`+5 before the three 
tests
   * Injects the tika address in extraction handler
   * Tears down the tika server after the test
   
   ```
   ...
   ok 37 export fails on non cloud mode # in 11193 ms
   Tika Server started on port 42650
   ok 38 using curl to extract a single pdf file # in 23696 ms
   ok 39 using the bin/solr post tool to extract content from pdf # in 21434 ms
   ok 40 using the bin/solr post tool to crawl web site # in 24926 ms
   Stopping Tika Server container
   ok 41 healthcheck on cloud solr # in 15160 ms
   ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to