cpoerschke commented on code in PR #3789: URL: https://github.com/apache/solr/pull/3789#discussion_r2455205016
########## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ########## @@ -228,3 +228,9 @@ Due to Lucene 10 changes (https://github.com/apache/lucene/pull/12875), `PathHie </analyzer> </fieldType> ---- + +=== Renaming in Vector Search +Attention: + +* The `llm` module has been renamed to `language-models`. +* The HNSW parameters `hnswMaxConnections` and `hnswBeamWidth` have been renamed to `hnswM` and `hnswEfConstruction`, respectively, so they must be updated accordingly in the schema.xml file. Review Comment: Curiosity only, I wonder if unused attributes are permitted in the schema e.g. might one go * from `hnswMaxConnections="10" hnswBeamWidth="40"` on Solr9 * to `hnswMaxConnections="10" hnswBeamWidth="40" hnswM="10" hnswEfConstruction="40"` on Solr9 * to `hnswMaxConnections="10" hnswBeamWidth="40" hnswM="10" hnswEfConstruction="40"` on Solr10 * to `hnswM="10" hnswEfConstruction="40"` on Solr10 conceptually? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
