janhoy commented on code in PR #3805: URL: https://github.com/apache/solr/pull/3805#discussion_r2457053079
########## dev-docs/changelog.adoc: ########## @@ -72,17 +72,17 @@ use that information. Example: [source, properties] ---- # Changelog generator settings (./gradlew writeChangelog) -user.name=John Doe -user.githubid=johngithub -user.asfid=johnapache +user.name=Alex Doe +user.githubid=alex_githubid +user.asfid=alex_asfid ---- TIP: Aliases for `writeChangelog` task are `changelog` and `newChangelog`. == 4. Writing Good Entries * **Audience** is end-users and administrators, not committers. -* If the change is super minor, like a typo, don't bother adding a yaml file +* If the change is super minor, like a typo, don't bother adding a yaml file. Review Comment: There is a PR label. But one can still merge even if that check fails. Q: Can contributors set labels on their own PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
