dsmiley commented on PR #3793: URL: https://github.com/apache/solr/pull/3793#issuecomment-3456343790
Keeping them in the same package created a split-package situation, which was problematic for javadoc. So I changed "impl" for "apache", and so there are a bunch of import statement changes. I also moved some tests specific to these classes along with them into the tests of the test framework, for at least one reason being to retain package access. I found I needed to make a member or inner class or two public in solrj for this move, which is a good outcome since if someone wants to create their very own variant, we wouldn't want them to do so in whatever package they want, not Solr's. Looks like there's one failing test related to this move. I'll fix and merge this branch tonight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
