[ 
https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18034757#comment-18034757
 ] 

David Smiley commented on SOLR-17458:
-------------------------------------

Cool; looking forward that.

Q: I'm looking at 
`org.apache.solr.metrics.SolrMetricProducer#initializeMetrics` and see the 2nd 
arg is Attributes.  I don't see consistency on what is done with the 
attributes.  In a some (many?) places (such as HttpShardHandlerFactory to pick 
one arbitrarily), it's {_}ignored{_}, and the method will call other metrics 
producing methods and pass in Attributes.empty().  That looks wrong.  If we 
agree it's wrong or needless... then maybe the SolrMetricsContext should hold 
the "base" Attributes, and we remove this arg from initializeMetrics.

> Metrics: switch from DropWizard to OpenTelemetry
> ------------------------------------------------
>
>                 Key: SOLR-17458
>                 URL: https://issues.apache.org/jira/browse/SOLR-17458
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Matthew Biscocho
>            Assignee: Matthew Biscocho
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 10.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Solr currently captures metrics with Dropwizard 4. There was some limitations 
> to Dropwizard, biggest one being metrics without tags/attributes making 
> aggregation difficult and requires the Prometheus Exporter to work with 
> Grafana.
> Creating this to track and explore integrating OpenTelemetry into Solr and 
> possibly replace Dropwizard giving a larger exposure of observability tools.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to