[
https://issues.apache.org/jira/browse/SOLR-17562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18035152#comment-18035152
]
Jason Gerlowski commented on SOLR-17562:
----------------------------------------
bq. see this thread of mine:
https://lists.apache.org/thread/kwksgomjrj0wh2ygc4snfvm9j2pb1knx – happy to
discuss that on the list if desired.
No need - I have no issue with 9.x releases continuing to happen. I was just
trying to convey that *if* a deprecation is necessary, there likely isn't an
opportunity to get that in before 10.0
Now...is a deprecation needed in this case?
I was definitely assuming so. I get that it's a very trivial change to require
of users on a major version upgrade. But there are other very similar changes
(e.g. class renams) where we *do* opt for deprecation in most cases. On the
other hand though, I spent a bit of time looking at a few other package-changes
we've made in the past and I don't see much deprecation. e.g. the
"split-package" fixing that Kevin R did as a part of SOLR-16040.
So I'm on the fence I guess.
I'll send out a dev@ email about this; get some more eyes on the question.
> Unify v2 API streaming support
> ------------------------------
>
> Key: SOLR-17562
> URL: https://issues.apache.org/jira/browse/SOLR-17562
> Project: Solr
> Issue Type: Improvement
> Components: v2 API
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Labels: pull-request-available
> Fix For: 9.9, 10.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Several v2 APIs return raw files or streams of data, including:
> {{ZooKeeperReadAPI}}, {{NodeFileStore}}, and {{CoreReplication.fetchFile}}.
> But the APIs vary slightly in how they support this: ZooKeeperReadAPI uses
> the deprecated "ContentStream" with "RawResponseWriter", NodeFileStore
> directly attaches a "SolrCore.RawWriter" to the underlying SolrQueryResponse,
> and CoreReplication follows the JAX-RS best practice of using the
> "StreamingOutput" interface.
> This ticket aims to align all of these approaches and document our approach
> in {{dev-docs/apis.adoc}} or a similar file.
> The preferred approach ([see discussion
> here|https://github.com/apache/solr/pull/2734]) at the time of writing is to
> use StreamingOutput. If this doesn't change, this ticket will need to:
> * modify our Java codegen template and related code to support this new
> response type. (Java codegen currently requires that all responses subclass
> SolrJerseyResponse)
> * remove the "x-omitFromCodegen" tag from any APIs using StreamingOutput (see
> ReplicationApis.fetchFile for an example)
> * Switch other raw-file/streaming APIs over to using StreamingOutput.
> Validate v1 and v2 responses.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
