dsmiley commented on code in PR #3856: URL: https://github.com/apache/solr/pull/3856#discussion_r2525709672
########## solr/solr-ref-guide/modules/configuration-guide/pages/solr-properties.adoc: ########## @@ -68,6 +70,10 @@ NOTE: Properties marked with "!" indicate inverted meaning between old and new p |solr.logs.dir|solr.log.dir|server/logs|Specifies the directory where Solr logs are stored. +|solr.logs.requestlog.retain.enabled|SOLR_REQUESTLOG_ENABLED|true|Specifies if request logs should be created. Review Comment: As we apparently don't _anymore_ have "jetty" prefix sys-props or have "jetty" in nearly any system prop (judging from solr-properties.adoc), the name you chose is fine. My comment is for the docs. Generally, if we have props that control a jetty thing, we really should say so in the docs IMO. Our prop names no longer implicitly convey that information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
