epugh commented on code in PR #3860:
URL: https://github.com/apache/solr/pull/3860#discussion_r2529883984
##########
solr/core/src/test/org/apache/solr/cloud/TestRandomFlRTGCloud.java:
##########
@@ -607,8 +586,7 @@ private static SolrDocumentList
getSolrDocumentList(Map<String, Object> response
@SuppressWarnings("unchecked")
private static SolrDocumentList getDocsFromJsonResponse(
- final boolean expectList, final String rsp) throws IOException {
- Map<String, Object> nl = (Map<String, Object>) ObjectBuilder.fromJSON(rsp);
+ final boolean expectList, final NamedList<?> nl) throws IOException {
Review Comment:
Reading back through your commit, this is all making a LOT more sense. I
have a tendency to try and overly minimize my changes, which was leading me
into wedging in a weird set of changes. This is all MUCH nicer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
