epugh commented on PR #3862: URL: https://github.com/apache/solr/pull/3862#issuecomment-3539114461
> > Nowhere do we pass in more then one type of Replica, but we have this getReplicas(EnumSet.of(Replica.Type.NRT)),docCollection) pattern. What if we just change it to getReplicas(Replica.Type.NRT,docCollection). > > Firstly, docCollection should come first as it's the source of the information. Secondly, to your question, I suggest a `Predicate<Replica>`. You might also consider a `replicaStream(docCollection)` method so the caller can do whatever with that stream. I think that's getting too ambitious for me. I'll go ahead and reorder the params and call it good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
