tflobbe commented on code in PR #3840:
URL: https://github.com/apache/solr/pull/3840#discussion_r2533944984
##########
solr/server/etc/jetty-http.xml:
##########
@@ -40,9 +40,9 @@
</Arg>
<Set name="host"><Property name="solr.host.bind"
default="127.0.0.1"/></Set>
<Set name="port"><Property name="solr.port.listen" default="8983"
/></Set>
- <Set name="idleTimeout"><Property name="solr.jetty.http.idleTimeout"
default="120000"/></Set>
- <Set name="acceptorPriorityDelta"><Property
name="solr.jetty.http.acceptorPriorityDelta" default="0"/></Set>
- <Set name="acceptQueueSize"><Property
name="solr.jetty.http.acceptQueueSize" default="0"/></Set>
+ <Set name="idleTimeout"><Property name="solr.jetty.http.timeout.ms"
default="120000"/></Set>
Review Comment:
I'm not sure I like removing the "idle", it makes the parameter confusing,
as the user wouldn't know what kind of timeout this is (my first thought would
be this is a request timeout)
##########
solr/server/etc/jetty-https.xml:
##########
@@ -66,8 +66,8 @@
<Set name="host"><Property name="solr.host.bind"
default="127.0.0.1"/></Set>
<Set name="port"><Property name="solr.jetty.https.port" default="8983"
/></Set>
<Set name="idleTimeout"><Property name="solr.jetty.https.timeout"
default="120000"/></Set>
Review Comment:
Note that this timeout property is different than the new one you are
adding, for the same thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
