David Smiley created SOLR-17994:
-----------------------------------

             Summary: Rename HttpClientBuilderFactory to SolrClientCustomizer
                 Key: SOLR-17994
                 URL: https://issues.apache.org/jira/browse/SOLR-17994
             Project: Solr
          Issue Type: Improvement
          Components: SolrJ
            Reporter: David Smiley
            Assignee: David Smiley


HttpClientBuilderFactory's name doesn't make sense anymore, if it ever did.  It 
has evolved.  It's not a factory for a builder of HttpClients, as its name 
might suggest.  It's a customizer for a SolrClient that was recently 
constructed.  At present it's only used for Http2SolrClient (Jetty) but it's 
quite plausible to imagine using it for the JDK one, if we so choose.  We might 
evolve it to configure a builder, which would be nice because it would make it 
easier to make clients immutable (no back-doors).  Still, calling this a 
SolrClient customizer still sounds like a good name.  But it's not a factory, 
and it's not a builder!  It's definitely a customizer/configurer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to