epugh commented on PR #3889: URL: https://github.com/apache/solr/pull/3889#issuecomment-3575341870
> Not trying to shove this in... happy to hear feedback. If I were to be slightly less aggressive and touch fewer things, CloudSolrClient could stay. But I think it's a major CloudSolrClient abstraction that users should be seeing. And I hate "impl" package ;-). With this PR, it's what's left is more internal-y things, plus the primary 2 Http SolrClients which aren't very internally but one will go to its own package (jetty) and honestly the other deserves one too (jdk). I would much prefer to get this in NOW for 10, as if it's an 11 only thing it will make backporting harder. Having said that, we also need to get to "done done" so we can get 10 out soon! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
