dsmiley commented on code in PR #3901:
URL: https://github.com/apache/solr/pull/3901#discussion_r2573045661
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClusterStateProvider.java:
##########
Review Comment:
FYI @jdyer1 ... even though HttpClusterStateProvider is exists in the
`apache` package in the test framework, it will be removed, freeing up this
name for use here.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateBaseSolrClient.java:
##########
@@ -784,5 +784,9 @@ public Builder setPollQueueTime(long pollQueueTime,
TimeUnit unit) {
* Create a {@link ConcurrentUpdateBaseSolrClient} based on the provided
configuration options.
*/
public abstract ConcurrentUpdateBaseSolrClient build();
+
+ public HttpSolrClientBase getClient() {
Review Comment:
needed occasional getters to expose things that are now in different
packages and thus not exposed. A protected field on a builder isn't accessible
to the class being constructed that **uses** the builder, if it's in another
package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
