epugh commented on code in PR #3904: URL: https://github.com/apache/solr/pull/3904#discussion_r2576529028
########## solr/packaging/test/test_create_collection2.bats: ########## @@ -0,0 +1,62 @@ +#!/usr/bin/env bats Review Comment: I'm going to move it to junit. My challenge with the junit tests, and it might just be my knowledge, is that i sturggle to really feel like I understand how these junit tests really map to the real world. Whereas the bats tests map much closer. Maybe because I think from outside solr looking in, versus as a java coder, inside looking out. For example, the logic of creating a fake directory to trigger the failure case. I get it in bats, and don't have a good sense of doing that in junit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
