epugh commented on code in PR #3920:
URL: https://github.com/apache/solr/pull/3920#discussion_r2588738424
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -152,7 +152,7 @@ public class MiniSolrCloudCluster {
+ "</solr>\n";
private final Object startupWait = new Object();
- private volatile ZkTestServer zkServer; // non-final due to injectChaos()
+ private final ZkTestServer zkServer;
Review Comment:
Reverted. I don't have confidence in my understanding of when to use
volatile ;-)
##########
solr/test-framework/src/java/org/apache/solr/util/RevertDefaultThreadHandlerRule.java:
##########
@@ -35,7 +35,7 @@ protected void before() throws Throwable {
if (!applied.getAndSet(true)) {
UncaughtExceptionHandler p =
Thread.getDefaultUncaughtExceptionHandler();
try {
- // Try to initialize a zookeeper class that reinitializes default
exception handler.
+ // Try to initialize a zookeeper class that reinitialized default
exception handler.
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
