HoustonPutman commented on code in PR #3930:
URL: https://github.com/apache/solr/pull/3930#discussion_r2603710033
##########
solr/core/src/test/org/apache/solr/search/TestSolrQueryParser.java:
##########
@@ -1839,24 +1842,55 @@ public void testFieldExistsQueries() throws SyntaxError
{
+ query
+ "\".",
createdQuery instanceof ConstantScoreQuery);
- assertTrue(
- "PointField with NaN values must include \"exists or NaN\" if
the field doesn't have norms or docValues: \""
- + query
- + "\".",
- ((ConstantScoreQuery) createdQuery).getQuery() instanceof
BooleanQuery);
- assertEquals(
- "PointField with NaN values must include \"exists or NaN\" if
the field doesn't have norms or docValues: \""
- + query
- + "\". This boolean query must be an OR.",
- 1,
- ((BooleanQuery) ((ConstantScoreQuery) createdQuery).getQuery())
- .getMinimumNumberShouldMatch());
- assertEquals(
- "PointField with NaN values must include \"exists or NaN\" if
the field doesn't have norms or docValues: \""
- + query
- + "\". This boolean query must have 2 clauses.",
- 2,
- ((BooleanQuery) ((ConstantScoreQuery)
createdQuery).getQuery()).clauses().size());
+ if (schemaField.getType().isPointField()) {
Review Comment:
Yeah, I do too, but when in Rome... We can remove the tests in another PR
but I didn't want to remove tests when making the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
