dsmiley commented on code in PR #3859:
URL: https://github.com/apache/solr/pull/3859#discussion_r2603468214
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -877,7 +879,11 @@ public static void checkDiskSpace(
SolrRequest.METHOD.GET, "/admin/metrics",
SolrRequest.SolrRequestType.ADMIN, params);
req.setResponseParser(new InputStreamResponseParser("prometheus"));
- SolrResponse resp = req.process(cloudManager.getSolrClient());
+ var cloudClient = (CloudHttp2SolrClient) cloudManager.getSolrClient();
+ var http2Client = (Http2SolrClient) cloudClient.getHttpClient();
Review Comment:
after you sync from main, please rename this var without the `2`. IMO we
shouldn't have this number 2 in our client var names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
