epugh commented on PR #3938: URL: https://github.com/apache/solr/pull/3938#issuecomment-3637376763
I am a bit ambivalent... I believe Claude, however I really dislike `We avoid using cluster.getSolrClient() because it may have a background refresh job` because how would any human being understand that? There isn't anything to help protect the poor human being writing a test from using the `cluster.getSolrClient()` method... I really wish there were some strong patterns in our tests (not fifteen different weak patterns!) that helped us write tests that would not be flaky. Without the level of deep deep Solr knowledge that some folks have. Or, do we need a pattern that says "When writing tests, make sure to run Claude to review it because you can't possibly keep all the things in your head and there is no pattern". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
