ilariapet commented on code in PR #3919: URL: https://github.com/apache/solr/pull/3919#discussion_r2614102967
########## solr/modules/language-models/src/test-files/solr/collection1/conf/schema.xml: ########## @@ -39,6 +40,8 @@ <field name="_version_" type="plong" indexed="true" stored="true" multiValued="false" /> <field name="_text_" type="text_general" indexed="true" stored="false" multiValued="true"/> <copyField source="*" dest="_text_"/> + <field name="vectorised" type="boolean" indexed="true" stored="false" docValues="true" default="false"/> Review Comment: I understand your point. I didn’t use a dynamic field because it’s not possible to use the `default` property with it. That said, this schema appears to be used only by the LLM module, so I think keeping a specific field makes sense. However, if you’d prefer a more generic name like boolean_field, I can rename it. One more thing: I’m going to rename the file from `schema.xml` to `schema-language-models.xml` to avoid confusion. I discussed this with @alessandrobenedetti this morning as well, and he agrees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
