ppkarwasz commented on code in PR #3603:
URL: https://github.com/apache/solr/pull/3603#discussion_r2628453203
##########
solr/modules/extraction/build.gradle:
##########
@@ -24,22 +24,6 @@ ext {
useSecurityManager = false
}
-configurations.configureEach {
- // Exclude SpotBugs Annotations, a `compileOnlyApi` dependency of Log4j.
- //
- // Why:
- // - Log4j includes them only to silence harmless `-Xlint:classfile` warnings
- // when consumers reference classes annotated with `@SuppressFBWarnings`.
- // Without the jar, compilation may emit warnings (and fail under
`-Werror`).
- // See:
https://github.com/apache/logging-log4j2/issues/3110#issuecomment-2423586754
- //
- // - However, SpotBugs Annotations are LGPL-2.1 licensed. Including them,
- // even at compile time, breaks our license compatibility checks.
- //
- // Net result: unless compiling with `-Werror`, it is safe to exclude the
jar.
- exclude group: "com.github.spotbugs", module: "spotbugs-annotations"
-}
-
Review Comment:
This is no longer needed due to apache/logging-log4j2#3985.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
