epugh commented on code in PR #3708:
URL: https://github.com/apache/solr/pull/3708#discussion_r2634770255
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseHS.java:
##########
@@ -190,9 +194,31 @@ public static String getQueryResponse(String wt,
SolrParams params) throws Excep
p.remove("qt");
p.set("indent", "true");
- DirectSolrConnection connection = new DirectSolrConnection(h.getCore());
- String raw = connection.request(path, p, null);
- return raw;
+ SolrCore core = h.getCore();
Review Comment:
Thanks for this... Yeah, when I finished I was like "Yay, great, no more
DirectSolrConnection." then I looked again at the class itself and the
recommended deprecation layer and then started thinking... "I am not sure
folding all that code wrapped up in DirectSolrConnection is what we wanted"...
I am going to take another stab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
