Copilot commented on code in PR #3980: URL: https://github.com/apache/solr/pull/3980#discussion_r2644282422
########## solr/modules/extraction/src/java/org/apache/solr/handler/extraction/TikaServerExtractionBackend.java: ########## @@ -45,7 +45,10 @@ import org.eclipse.jetty.util.thread.ScheduledExecutorScheduler; import org.xml.sax.helpers.DefaultHandler; -/** Extraction backend using the Tika Server. It uses a shared Jetty HttpClient. */ +/** + * Extraction backend using the Tika Server. It uses a shared Jetty HttpClient. TODO: Get rid of the + * import of org.apache.tika.sax.BodyContentHandler; + */ Review Comment: The TODO comment indicates that the import of `org.apache.tika.sax.BodyContentHandler` should be removed. This suggests incomplete removal of Tika dependencies. Since the goal of this PR is to remove the local Tika backend and its dependencies, this Tika 3.x dependency should ideally be eliminated if possible. Consider whether BodyContentHandler can be replaced with a Solr-specific implementation or if it's genuinely needed for the tikaserver backend. ########## solr/solr-ref-guide/modules/indexing-guide/pages/indexing-with-tika.adoc: ########## @@ -268,14 +249,11 @@ Example: `defaultField=\_text_` + [%autowidth,frame=none] |=== -|Optional |Default: local +|Optional |Default: `tikaserver` |=== + -Choose the backend to use for extraction. The options are `local` or `tikaserver`. -The `local` backend uses Tika libraries included with Solr to do the extraction, and is the default in Solr 9.x. -The `tikaserver` backend uses an external Tika server process to do the extraction, and -requires the `tikaserver.url` parameter to point to a running Tika Server. -**The `local` backend is deprecated and will be removed in a future release.** +Specifies the backend to use for extraction. As of Solr 10, only `tikaserver` is supported. +This parameter is optional since `tikaserver` is the only available backend. Review Comment: The documentation incorrectly states "As of Solr 10" when this change is being backported to Solr 9.11 (branch_9x). This should be updated to "As of Solr 9.11" to accurately reflect when this feature was removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
