Gus Heck created SOLR-18043:
-------------------------------
Summary: Dead Code?: SolrDispatchFilter.abortErrorMessage
Key: SOLR-18043
URL: https://issues.apache.org/jira/browse/SOLR-18043
Project: Solr
Issue Type: Bug
Components: Server
Affects Versions: main(11.0)
Reporter: Gus Heck
In reading code I discovered that the only reason HttpSolrCall (HSC) needs a
reference to SolrDispatchFilter (SDF) is that it wants to [check and possibly
use|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java#L421]
the value stored in SDF.abortErrorMessage.
However, it appears that this property is never set and will always be null, so
we can probably remove the reference to SDF, the if block that checks for null
before doing anything in HSC, and the property on SDF.
The property dates back to 2007, so I'm filing this ticket in case someone
thinks "Oh no! we've lost something important"... If I don't hear objections in
week or so, I'll proceed with removal of the dead code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
