dsmiley commented on PR #3945: URL: https://github.com/apache/solr/pull/3945#issuecomment-3704059717
No; that proposed solution, I can see, is mimicking the approach that we did for the new UI module. That module is difficult to build, unlike the extraction module. The issue here is running specific tests. Lets instead categorically skip docker tests, which seems convenient. Did you have concerns with my previous suggestion of this? FWIW I've done this very thing in another project. For inspiration, see this PR: https://github.com/apache/solr/pull/2825 So imagine a UsesDocker annotation. It could be filtered like this: `./gradlew test -Ptests.filter="default and not(@usesdocker)"` which I would apply to our s390x CI build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
