Copilot commented on code in PR #3998:
URL: https://github.com/apache/solr/pull/3998#discussion_r2657457570
##########
solr/solrj/build.gradle:
##########
@@ -31,6 +31,7 @@ dependencies {
implementation libs.fasterxml.jackson.core.annotations
implementation libs.fasterxml.jackson.core.core
api project(":solr:api")
+ api platform(libs.fasterxml.jackson.bom)
Review Comment:
The Jackson BOM platform dependency should be declared before the Jackson
implementation dependencies (lines 30-32) to properly control their versions.
In Gradle, platform/BOM dependencies need to be declared before the actual
library dependencies they manage to be effective.
This pattern is consistently followed in other modules in the codebase - for
example, in solr/api/build.gradle, the BOM is declared at line 65 before any
Jackson library dependencies at line 70. Similarly, in modules like
gcs-repository, opentelemetry, and s3-repository, platform dependencies are
declared at the beginning of the dependencies block.
Consider moving this line to appear before line 30, or at least before the
Jackson library dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
